[Fix] 회원가입 학번 입력 로직 수정 #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PowerSpinner for Signup page
- Add Spinner Data Logic - Remove autoInputMajor temporary
Jokwanhee
reviewed
Jun 3, 2024
koin/src/main/java/in/koreatech/koin/ui/signup/SignUpWithDetailInfoActivity.kt
Show resolved
Hide resolved
koin/src/main/java/in/koreatech/koin/ui/signup/SignUpWithDetailInfoActivity.kt
Outdated
Show resolved
Hide resolved
koin/src/main/java/in/koreatech/koin/ui/signup/SignUpWithDetailInfoActivity.kt
Outdated
Show resolved
Hide resolved
|
|
||
| private val _getDeptErrorMessage = MutableLiveData<String>() | ||
| val getDeptErrorMessage: LiveData<String> get() = _getDeptErrorMessage | ||
| val depts: StateFlow<List<String>> = flow { emit(getDeptNamesUseCase()) } |
There was a problem hiding this comment.
backing property 에 대해서 알아봐도 좋을 것 같아요!
https://stackoverflow.com/questions/53050257/viewmodel-backing-properties-kotlin
ThirFir
approved these changes
Jun 11, 2024
|
|
||
| private val _getDeptErrorMessage = MutableLiveData<String>() | ||
| val getDeptErrorMessage: LiveData<String> get() = _getDeptErrorMessage | ||
| val depts: StateFlow<List<String>> = flow { emit(getDeptNamesUseCase()) } |
There was a problem hiding this comment.
해당 부분을 Flow가 아닌 StateFlow로 했어야 하는 이유가 혹시 무엇인가요?
There was a problem hiding this comment.
Flow 로 하게 되는 경우 화면을 다시 불러오게 되는 경우 depts 가 다시 collect 되면서 getDeptNamesUseCase() 가 다시 호출되는거로 알고 있어요.
학과명은 유저가 테스크를 진행하는 동안 바뀔 일이 적은 것이라 생각해서 불필요한 API 호출을 줄이려고 했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
상세 작업 내용
작업 결과물
회원가입 화면